-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): noir mirror base commit #4969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@TomAFrench fixed the issue, see example noir-lang/noir#4485 - however note any fixups on Noir side should be pulled over from aztec-packages before merging, otherwise they will crop up again. |
TomAFrench
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
PhilWindle
pushed a commit
that referenced
this pull request
Mar 6, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.26.4</summary> ## [0.26.4](aztec-package-v0.26.3...aztec-package-v0.26.4) (2024-03-06) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.26.4</summary> ## [0.26.4](barretenberg.js-v0.26.3...barretenberg.js-v0.26.4) (2024-03-06) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.26.4</summary> ## [0.26.4](aztec-cli-v0.26.3...aztec-cli-v0.26.4) (2024-03-06) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.26.4</summary> ## [0.26.4](aztec-packages-v0.26.3...aztec-packages-v0.26.4) (2024-03-06) ### Features * **avm:** ALU <--> MAIN inter table relation on intermediate registers copy ([#4945](#4945)) ([8708131](8708131)), closes [#4613](#4613) * Circuit checker class ([#4931](#4931)) ([4eba266](4eba266)) * Compute out hash in circuits [#4561](#4561) ([#4873](#4873)) ([06a9116](06a9116)) ### Bug Fixes * **ci:** Noir mirror base commit ([#4969](#4969)) ([546c666](546c666)) * Fix release ([#4994](#4994)) ([19a8728](19a8728)) ### Miscellaneous * Use public constructors where possible ([#4937](#4937)) ([225aad6](225aad6)) </details> <details><summary>barretenberg: 0.26.4</summary> ## [0.26.4](barretenberg-v0.26.3...barretenberg-v0.26.4) (2024-03-06) ### Features * **avm:** ALU <--> MAIN inter table relation on intermediate registers copy ([#4945](#4945)) ([8708131](8708131)), closes [#4613](#4613) * Circuit checker class ([#4931](#4931)) ([4eba266](4eba266)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
AztecBot
added a commit
to AztecProtocol/barretenberg
that referenced
this pull request
Mar 7, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.26.4</summary> ## [0.26.4](AztecProtocol/aztec-packages@aztec-package-v0.26.3...aztec-package-v0.26.4) (2024-03-06) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.26.4</summary> ## [0.26.4](AztecProtocol/aztec-packages@barretenberg.js-v0.26.3...barretenberg.js-v0.26.4) (2024-03-06) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-cli: 0.26.4</summary> ## [0.26.4](AztecProtocol/aztec-packages@aztec-cli-v0.26.3...aztec-cli-v0.26.4) (2024-03-06) ### Miscellaneous * **aztec-cli:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.26.4</summary> ## [0.26.4](AztecProtocol/aztec-packages@aztec-packages-v0.26.3...aztec-packages-v0.26.4) (2024-03-06) ### Features * **avm:** ALU <--> MAIN inter table relation on intermediate registers copy ([#4945](AztecProtocol/aztec-packages#4945)) ([8708131](AztecProtocol/aztec-packages@8708131)), closes [#4613](AztecProtocol/aztec-packages#4613) * Circuit checker class ([#4931](AztecProtocol/aztec-packages#4931)) ([4eba266](AztecProtocol/aztec-packages@4eba266)) * Compute out hash in circuits [#4561](AztecProtocol/aztec-packages#4561) ([#4873](AztecProtocol/aztec-packages#4873)) ([06a9116](AztecProtocol/aztec-packages@06a9116)) ### Bug Fixes * **ci:** Noir mirror base commit ([#4969](AztecProtocol/aztec-packages#4969)) ([546c666](AztecProtocol/aztec-packages@546c666)) * Fix release ([#4994](AztecProtocol/aztec-packages#4994)) ([19a8728](AztecProtocol/aztec-packages@19a8728)) ### Miscellaneous * Use public constructors where possible ([#4937](AztecProtocol/aztec-packages#4937)) ([225aad6](AztecProtocol/aztec-packages@225aad6)) </details> <details><summary>barretenberg: 0.26.4</summary> ## [0.26.4](AztecProtocol/aztec-packages@barretenberg-v0.26.3...barretenberg-v0.26.4) (2024-03-06) ### Features * **avm:** ALU <--> MAIN inter table relation on intermediate registers copy ([#4945](AztecProtocol/aztec-packages#4945)) ([8708131](AztecProtocol/aztec-packages@8708131)), closes [#4613](AztecProtocol/aztec-packages#4613) * Circuit checker class ([#4931](AztecProtocol/aztec-packages#4931)) ([4eba266](AztecProtocol/aztec-packages@4eba266)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we are truly not using the noir .gitrepo file at all, except as a pull utility. We just find the last merge on Noir side. However, care should be taken that any conflicts that were fixed in the noir sync branch should make their way into aztec packages before a merge.
Fixes #4961.
Also makes sure commit messages pushed to Noir's branch reference full aztec-packages PR links.